Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface with more functions from ClipperLib #42

Open
plut opened this issue Jan 8, 2021 · 2 comments
Open

Interface with more functions from ClipperLib #42

plut opened this issue Jan 8, 2021 · 2 comments

Comments

@plut
Copy link
Collaborator

plut commented Jan 8, 2021

(this is more a feature request than a true issue...)

Reading the documentation from ClipperLib, this library supports Minkowski sum and difference:

http://www.angusj.com/delphi/clipper/documentation/Docs/Units/ClipperLib/Functions/MinkowskiSum.htm

However these are not interfaced by Clipper.jl. I looked up a bit and neither are they present in libcclipper (this is not surprising). Since these two functions are quite useful, it would be nice to have them exported in Clipper.jl!

@plut
Copy link
Collaborator Author

plut commented Oct 1, 2021

So I have written some code that makes these two functions (Minkowski sum and difference) visible in the Clipper_jll.jl library. What is the procedure for submitting a PR on this topic? Should I send the PR directly to Yggdrasil (who will review it then)? How is it then propagated to Clipper_jll.jl (is there an auto-build?)

@sjkelly
Copy link
Member

sjkelly commented Oct 3, 2021

That sounds about right. A PR to Yggdrasil, once merged, will update the _jll. Please tag me in the Yggdrail PR so I can test locally before merge in Yggdrasil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants