-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a .zip
writer
#115
Comments
Only half joking, ideally we dumb down/nag about Shapefile writes, and default/advice to things like geopackage instead. And post about http://switchfromshapefile.org/ |
Probably we need a native geopackage writer first ;) |
Fair point, let's add it to the board and put it higher prio than this zip writer :) |
The reader in GeoPackage.jl semi works, it just needs to be cleaned up a lot + optimized :D. I'm not sure about the writer though, that seems like a lot of work... |
So that you know, ZipFile.jl can be super slow when compressing large files: https://discourse.julialang.org/t/file-zipping-taking-longer-for-large-files/115963. I made https://github.com/JuliaIO/ZipArchives.jl to save Zarr data in a |
This would be as simple as amending the function here
Shapefile.jl/src/writer.jl
Line 93 in 69bad03
to switch behaviour based on the file name and return ZipFile file descriptors instead. This would be similar to the behaviour we introduced in
.zip
reading.See
https://github.com/fhs/ZipFile.jl/blob/a599b0aac5d17403fdbbc4ea63612be299cf8417/src/ZipFile.jl#L14-L1
for some example code that can do this, it seems quite straightforward.
The text was updated successfully, but these errors were encountered: