Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: base repository with strict null checks #467

Merged
merged 9 commits into from
Dec 30, 2024

Conversation

abdou6666
Copy link
Member

Motivation

This PR updates base-repository typing to work correctly in strictNullChecks mode.

Fixes #443

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

api/src/utils/generics/base-repository.ts Outdated Show resolved Hide resolved
api/src/utils/generics/base-repository.ts Outdated Show resolved Hide resolved
api/src/utils/generics/base-repository.ts Outdated Show resolved Hide resolved
api/src/utils/pagination/pagination-query.dto.ts Outdated Show resolved Hide resolved
@abdou6666 abdou6666 requested a review from marrouchi December 20, 2024 07:42
@abdou6666 abdou6666 mentioned this pull request Dec 20, 2024
9 tasks
@abdou6666 abdou6666 changed the title Fix/base repository with strict null checks Fix: base repository with strict null checks Dec 20, 2024
api/src/utils/generics/base-repository.ts Outdated Show resolved Hide resolved
api/src/utils/generics/base-repository.ts Outdated Show resolved Hide resolved
api/src/utils/pagination/pagination-query.dto.ts Outdated Show resolved Hide resolved
api/src/utils/generics/base-repository.ts Dismissed Show dismissed Hide dismissed
@marrouchi marrouchi merged commit e489bc5 into main Dec 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🤔 [ISSUE] - enabled strictNullChecks
2 participants