Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the warnings introduced by #2162 into errors #2167

Open
sauclovian-g opened this issue Dec 20, 2024 · 2 comments
Open

Make the warnings introduced by #2162 into errors #2167

sauclovian-g opened this issue Dec 20, 2024 · 2 comments
Labels
easy Issues that are expected to be easy to resolve and might therefore be good for new contributors tech debt Issues that document or involve technical debt topics: error-handling Issues involving the way SAW responds to an error condition topics: error-messages Issues involving the messages SAW produces on error type: enhancement Issues describing an improvement to an existing feature or capability
Milestone
Someday

Comments

@sauclovian-g
Copy link
Contributor

The cleanup associated with issue #2162 (q.v.) introduced warnings for certain type errors that were not previously checked.

These should be converted to errors, but not before at least one release has gone out with the warning behavior.
@sauclovian-g sauclovian-g added type: enhancement Issues describing an improvement to an existing feature or capability easy Issues that are expected to be easy to resolve and might therefore be good for new contributors topics: error-messages Issues involving the messages SAW produces on error tech debt Issues that document or involve technical debt topics: error-handling Issues involving the way SAW responds to an error condition labels Dec 20, 2024
@sauclovian-g sauclovian-g added this to the Someday milestone Dec 20, 2024
This was referenced Dec 20, 2024
Open
Open
@sauclovian-g
Copy link
Contributor Author

sauclovian-g commented Dec 20, 2024 •
edited
Loading

Note that both the error message tests added to test_type_errors for this issue (err006-009) and one of the tests in issue 2162's own tests (test2162/test2.saw) will change their behavior and need updating.

@sauclovian-g
Copy link
Contributor Author

#2169 is a blocker for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy Issues that are expected to be easy to resolve and might therefore be good for new contributors tech debt Issues that document or involve technical debt topics: error-handling Issues involving the way SAW responds to an error condition topics: error-messages Issues involving the messages SAW produces on error type: enhancement Issues describing an improvement to an existing feature or capability
Projects
None yet
Milestone
Someday
Development

No branches or pull requests
1 participant
@sauclovian-g