Replies: 1 comment
-
I was just working on some code that really could benefit from some more thorough unit test coverage, so a strong +1 to the plan outlined above. My only recommendation would be to add a few good test examples of each type of test, before moving on to the next type. A good test runner for 1 test is very different from a good test runner for 10 tests, so I think we'll learn a lot in adding a few before moving on. I'm also not convinced we'll be ready to pull out the dev server anytime soon (or if that's the right approach, vs. pulling out the installer) so +1 on getting tests working in this repo without having to block on that decision. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
As @FredKSchott mentioned in a previous PR comment, I'm spinning up a discussion around the best way to approach this.
I have looked into it a bit, just doing some basic preliminary research. It seems that the best way to handle the testing would be to have a mixture of unit and integration style tests.
The last tests are slower, but we shouldn't need as many if the request handler is adequately tested.
A few other notes:
To approach this, I would like to:
Ideally, this will make the PRs a bit more manageable and allow anyone who wants to, to help out after the testing is setup.
/cc @drwpow
Beta Was this translation helpful? Give feedback.
All reactions