Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrPredicate.impliesCandidatePredicate should call PredicateWithValueAndRanges.impliesCandidatePredicate #2872

Open
normen662 opened this issue Aug 8, 2024 · 0 comments

Comments

@normen662
Copy link
Contributor

This logic should be refactored in a way that it calls the implies-logic in PredicateWithValuesAndRanges instead of replicating that logic here. The only reason why that is not done right now is that this logic here indirectly excludes match mappings that involve index sargables (note that the parameter alias for created mappings is always empty). The fundamental problem for index sargables here is to synthesize the comparison range the scan should use. In fact, the predicate mapping that PredicateWithValueAndRanges.impliesCandidateRange() currently produces, refuses to return a proper comparison range (which should be coalesced from the query-originating ranges but that's not done as of now which is a bug).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant