Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minecraft default join message is not translated #5796

Open
jd07159 opened this issue May 9, 2024 · 4 comments · May be fixed by #5848
Open

Minecraft default join message is not translated #5796

jd07159 opened this issue May 9, 2024 · 4 comments · May be fixed by #5848
Labels
bug: confirmed Confirmed bugs in EssentialsX.

Comments

@jd07159
Copy link

jd07159 commented May 9, 2024 •
edited
Loading

Type of bug

Other unexpected behaviour

/ess dump all output

Error log (if applicable)

No response

Bug description

The quit message is translated, but the join message is not.

Steps to reproduce

custom-join-message: "none"
custom-quit-message: "none"

Expected behaviour

join messages must be translated.

Actual behaviour

The quit message is translated, but the join message is not.

Additional Information

javaw_WPs3wSoiFB
@jd07159 jd07159 added the bug: unconfirmed Potential bugs that need replicating to verify. label May 9, 2024
@DreiFxn
Copy link

DreiFxn commented May 21, 2024 •
edited
Loading

Hey,
I was about to open a bug report myself, but then I saw this.

Join messags are always english & the leave message always uses the players local.
image

I have been able to determine what is causing this error - allow-silent-join-quit: true - generates these incorrect join/leave messages. [Join message is always english & leave message is players local] If I set it to false, the messages are only in the player's local, as they are supposed to be.

I hope this helps to narrow down the problem.

  • Drei

@zp4rker
Copy link

zp4rker commented Jun 27, 2024

Hi,

Could you provide me your config.yml @DreiFxn or @jd07159, please? I'd like to replicate your issue. Took a quick look at the code, looks like a pretty simple fix but just want to test it out. Then I can submit a PR.

@jd07159
Copy link
Author

jd07159 commented Jun 27, 2024

Set allow-silent-join-quit: true and
Setting custom-join-message: "none" will allow you to reproduce the bug. @zp4rker

@zp4rker
Copy link

zp4rker commented Jun 27, 2024

Thanks. I've replicated the bug. Will try working on a solution.

zp4rker added a commit to zp4rker/Essentials that referenced this issue Jun 27, 2024
@zp4rker
Fix default Minecraft join message not being used
47ed96e 
Default Minecraft join message not used when allow-silent-join-quit set to true
Remove unnecessary broadcast of join message since default join message is working again

Fixes EssentialsX#5796
@zp4rker zp4rker linked a pull request Jun 27, 2024 that will close this issue
Open
3 tasks
@JRoy JRoy added bug: confirmed Confirmed bugs in EssentialsX. and removed bug: unconfirmed Potential bugs that need replicating to verify. labels Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: confirmed Confirmed bugs in EssentialsX.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix default Minecraft join message not being used zp4rker/Essentials
4 participants
@JRoy @zp4rker @DreiFxn @jd07159