Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to Flathub #2

Open
lostfictions opened this issue Dec 3, 2023 · 12 comments
Open

Publish to Flathub #2

lostfictions opened this issue Dec 3, 2023 · 12 comments
Assignees
Labels
enhancement New feature or request

Comments

@lostfictions
Copy link

Hi there, thanks a lot for making Pied! I was able to install and run it from the Flatpak bundle and it reconfigured speech-dispatcher without a problem (though it took me a few minutes to realize I had to download the first voice and then manually click again to activate it).

Any chance you might publish it to Flathub? I'm unlikely to remember to manually check for updates, and I'd love to have an easy way to recommend it to other people :)

@Elleo Elleo self-assigned this Dec 4, 2023
@Elleo Elleo added the enhancement New feature or request label Dec 4, 2023
@Elleo
Copy link
Owner

Elleo commented Dec 4, 2023

Hi @lostfictions!

Yes, I would like to eventually get it published on Flathub. However, this will likely take a little while, as I'll need to agree some exceptions with the Flathub team (being able to force speech dispatcher to restart requires some elevated privileges), plus I'll need to figure out a good way to bundle all the flutter dependencies with a release so that it can be built without network access (Flathub requires this)

In the meantime, I think for the next release I'll add in a very simple update checker, so that people using either the Flatpak or AppImage (when it's ready) will get notified when a new version is available.

@sonnyp
Copy link

sonnyp commented Dec 6, 2023

Hello, thanks for making this app which helped me learn about Piper https://floss.social/@sonny/111533945050274953

this will likely take a little while, as I'll need to agree some exceptions with the Flathub team (being able to force speech dispatcher to restart requires some elevated privileges)

FYI, this won't be a problem, simply explain why you need the permission when submitting the app to Flathub.

Cheers

@Elleo
Copy link
Owner

Elleo commented Dec 6, 2023

Hello, thanks for making this app which helped me learn about Piper https://floss.social/@sonny/111533945050274953

this will likely take a little while, as I'll need to agree some exceptions with the Flathub team (being able to force speech dispatcher to restart requires some elevated privileges)

FYI, this won't be a problem, simply explain why you need the permission when submitting the app to Flathub.

Cheers

That's great, thanks for the info!

@faveoled
Copy link

faveoled commented Feb 6, 2024

plus I'll need to figure out a good way to bundle all the flutter dependencies with a release so that it can be built without network access (Flathub requires this)

You could just repackage your binary tarball into a flatpak (build from source is not strictly necessary). See this for example (line 140):
https://github.com/flathub/com.github.KRTirtho.Spotube/blob/master/com.github.KRTirtho.Spotube.yml

@Elleo
Copy link
Owner

Elleo commented Feb 8, 2024

@faveoled thanks for the pointer! I'll try and set some time aside to look more deeply into publishing to flathub soon

@Jopp-gh
Copy link

Jopp-gh commented Mar 23, 2024

Hmm, I downloaded your flatpak and it looks like a zip, but it's not. Usually flatpak files contain just some data to access additional repos.

I must admit I don't know how I should install Pied. Usually I don't have similar issues

@Elleo
Copy link
Owner

Elleo commented Mar 24, 2024

Hmm, I downloaded your flatpak and it looks like a zip, but it's not. Usually flatpak files contain just some data to access additional repos.

I must admit I don't know how I should install Pied. Usually I don't have similar issues

Hi @Jopp-gh,

You can just run flatpak install com.mikeasoft.pied.flatpak in the directory you've downloaded the flatpak to

Hope that helps!

@mokazemi
Copy link

mokazemi commented Apr 2, 2024

@faveoled thanks for the pointer! I'll try and set some time aside to look more deeply into publishing to flathub soon

Thanks :) +1 for it.

@KAGEYAM4
Copy link

KAGEYAM4 commented May 1, 2024

Any update on this?

@boredsquirrel
Copy link

boredsquirrel commented Jun 26, 2024

flathub/flathub#5233

Here is a PR how not to do it. The exception should be no issue, as you have a very specific use case.

Please just start the process to get it going, you can change the source any time, for example to make it reproducible. Until then you can just use a tarball, and include the build instructions how to produce that tarball, everything fine.

Maybe be a bit more specific on these permissions, as they are really broad:

  - --device=dri
  - --filesystem=home
  - --talk-name=org.freedesktop.Flatpak

home access and that session bus allow full privilege escalation.

@barthalion @hfiguiere could you add a comment on that?

This is a great addition to the FOSS world, thanks!

@barthalion
Copy link

Nothing to add from me. We discuss sandbox holes during the initial review and may ask you to submit an exception to the linter if the use case is legit.

@A-Metal-Penguin
Copy link

Thank you SO much @Elleo for making Pied!!! I was up for hours last night trying to get things right. Within literally seconds of using Pied, everything was solved. Seriously, thank you soooooooo much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants