Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Add Pagination to /github #313

Open
Cahllagerfeld opened this issue Dec 17, 2022 · 3 comments
Open

Add Pagination to /github #313

Cahllagerfeld opened this issue Dec 17, 2022 · 3 comments
Assignees

Comments

@Cahllagerfeld
Copy link
Member

🙁 Actual behavior

The payload is huge and takes too slow, because it returns all github profiles

🙂 Expected behaviour

We should add pagination here, to reduce the size of the payload

🔢 Steps to Reproduce the Problem

No response

@pratiksabat
Copy link

Hey @Cahllagerfeld , I just had an idea on top of the one suggested by you. We can make our pagination dynamic in nature. What i mean by that is, normally people just show 10 records on each (which is the offset basically). We can make this dynamic by taking offset also as query params long with the page number.

This will help the end users in cases where their device size is lower, they might end up scrolling a little more. In this use case, our offset idea, can help the end user to change it according to their need.

Do let me know if i can work on this?? Or may be we can collaborate too..
This would be my first PR , so i am really exited for it...

@Cahllagerfeld
Copy link
Member Author

You can have a look at the /github/events endpoint. We're having pagination there already

@pratiksabat
Copy link

Hey @Cahllagerfeld , I tried setup gitpod and open the swagger page. But i am getting no response from the API.
I have 2 doubts, if that helps:-

  1. What's the data source for this server?? Where is it hosted ?? Or we should also setup a localDB for its working??
  2. If its a remote DB, then where can we find the access keys??

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants