Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Variables #86

Open
ghost opened this issue Sep 10, 2022 · 2 comments
Open

Extra Variables #86

ghost opened this issue Sep 10, 2022 · 2 comments

Comments

@ghost
Copy link

ghost commented Sep 10, 2022

Currently the variables provided through extra will be ignored by the processes in the case where I would use something that already exists, like PATH. Reasom being that the user provided extras are added last to the list.

I would suggest adding two options to this:

  1. strcat to already existing varibles

  2. Override already existing variables (add the user extras first)

Default behaviour being the way reproc handles it atm.

@DaanDeMeyer
Copy link
Owner

Sure, we can add REPROC_ENV_EXTEND_MERGE or so that merges environment variables with the same name. I'd be happy to review a PR that adds this

@ghost
Copy link
Author

ghost commented Sep 10, 2022

I'll start working on it then. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant