Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating of [ObservableObject] fails if interface is declared but not implemented #805

Open
1 task done
ShortDevelopment opened this issue Nov 30, 2023 · 2 comments · May be fixed by #769
Open
1 task done

Generating of [ObservableObject] fails if interface is declared but not implemented #805

ShortDevelopment opened this issue Nov 30, 2023 · 2 comments · May be fixed by #769
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior

Comments

@ShortDevelopment
Copy link

ShortDevelopment commented Nov 30, 2023 •
edited
Loading

Describe the bug

If a class implements an interface that itself inherits INotifyPropertyChanged or INotifyPropertyChanging but does not implement the interface methods, code-generation aborts.

Current tests only test diagnostics for an implementation of INotifyPropertyChanged / INotifyPropertyChanging:

dotnet/tests/CommunityToolkit.Mvvm.SourceGenerators.UnitTests/Test_SourceGeneratorsDiagnostics.cs

Lines 33 to 37 in 7b53ae2

[INotifyPropertyChanged]
public partial class SampleViewModel : INotifyPropertyChanged
{
public event PropertyChangedEventHandler? PropertyChanged;
}

Regression

No response

Steps to reproduce

interface IStuff : INotifyPropertyChanged {
   // ...
}

[ObservableObject]
class B : BaseClass, IStuff {
   // No implementation of INotifyPropertyChanged 
   // source generation
}

Expected behavior

The implementation of INotifyPropertyChanged should be generated.

Screenshots

No response

IDE and version

VS 2022

IDE version

No response

Nuget packages

  • CommunityToolkit.Mvvm (aka MVVM Toolkit)

Nuget package version(s)

8.2.2

Additional context

Similar to #620 but slightly different scenario

Help us help you

Yes, I'd like to be assigned to work on this item
@ShortDevelopment ShortDevelopment added the bug 🐛 An unexpected issue that highlights incorrect behavior label Nov 30, 2023
@ShortDevelopment ShortDevelopment linked a pull request Nov 30, 2023 that will close this issue
Open
9 tasks
@myblindy
Copy link

myblindy commented Dec 6, 2024

This is still an issue today.

@mklemarczyk
Copy link

mklemarczyk commented Dec 14, 2024 •
edited
Loading

Same is for Observable Property. Compiler does not take into consideration the other partial implementations.

public interface IClient {
  string Endpoint { get; }
}

// Does not compile, .NET8, .NET9
public partial class MsdnClient : ObservableObject, IClient {
  [ObservableProperty]
  private string endpoint;
}

// Does not compile either, .NET8, .NET9
[ObservableObject]
public partial class OsdbClient : IClient {
  [ObservableProperty]
  private string endpoint;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior
Projects
None yet
Milestone
No milestone
3 participants
@myblindy @mklemarczyk @ShortDevelopment