-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let node label field for node panel translation #52
base: master
Are you sure you want to change the base?
let node label field for node panel translation #52
Conversation
Hi there, just saw this and wanted to flag a few things:
Possible solutioni18n is important, so initial suggestion:
And the updated change, which I can help with:
WorkaroundAlternatively, if you are -currently- localising a title by overwriting the |
Yes, we considered that. So we use the |
@webfiltered As a result, most developers do not need to care about this |
Size calculations in litegraph will unfortunately be impacted - litegraph itself reads the |
Can you show me which LOC of js file? I'm so sorry about that I'm not familier enough with litegraph framework eh... |
Due to the fact that many third-party custom_nodes use getTitle() to implement predetermined logic, we cannot use the title field for node panel translation. Therefore, we have added the label as a translation field here.
See this problem we encountered:
AIGODLIKE/AIGODLIKE-ComfyUI-Translation#255