Sanity check if the double yarn install bug happens again #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The author of this PR, KenCorma, is not an activated member of this organization on Codecov. |
robinjhuang
requested changes
Nov 18, 2024
robinjhuang
requested changes
Nov 21, 2024
Changed verbiage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in ToDesktop that would cause the second yarn install to not have the correct "first run" flag. Although that is fixed this will catch any other scenario that would cause comfyUI to try to install again.
┆Issue is synchronized with this Notion page by Unito