Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comfy node install --fast-deps fails silently #216

Open
2 tasks
M1kep opened this issue Dec 4, 2024 · 3 comments
Open
2 tasks

comfy node install --fast-deps fails silently #216

M1kep opened this issue Dec 4, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@M1kep
Copy link

M1kep commented Dec 4, 2024

Describe the bug
When running comfy node install ...nodes..., if --fast-deps is passed, it exits very quickly and fails to install anything, with the only output being Execute from: /root/comfy/ComfyUI.

To Reproduce
Steps to reproduce the behavior

# Use a Python image with uv pre-installed
FROM ghcr.io/astral-sh/uv:python3.12-bookworm-slim

# Install the project into `/app`
WORKDIR /app

# Enable bytecode compilation
ENV UV_COMPILE_BYTECODE=1

# Copy from the cache instead of linking since it's a mounted volume
ENV UV_LINK_MODE=copy

RUN uv pip install --system comfy-cli

RUN apt update
RUN apt install -y git

# [DEFAULT]
# enable_tracking = False
COPY config.ini /root/.config/comfy-cli/config.ini

RUN comfy --skip-prompt install --nvidia --fast-deps
RUN comfy node install --fast-deps cg-use-everywhere qq-nodes-comfyui ComfyUI-KJNodes rgthree-comfy ComfyUI_TensorRT

Expected behavior
The nodes to install, while utilizing uv(I assume)

Nice to have

  • Terminal output
  • Screenshots
@M1kep M1kep added the bug Something isn't working label Dec 4, 2024
@M1kep
Copy link
Author

M1kep commented Dec 4, 2024

cm-cli.py seems to be failing due to it not expecting the --no-deps flag

#13 0.648 Execute from: /root/comfy/ComfyUI
#13 0.957 Command output:
#13 0.957
#13 0.957 Command error output:
#13 0.958 Usage: cm-cli.py install [OPTIONS] NODES...
#13 0.958 Try 'cm-cli.py install --help' for help.
#13 0.958 ╭─ Error ──────────────────────────────────────────────────────────────────────╮
#13 0.958 │ No such option: --no-deps Did you mean --mode?                               │
#13 0.958 ╰──────────────────────────────────────────────────────────────────────────────╯
#13 0.958
#13 0.958 Return code: 2
#13 0.959 Command that failed: ['/usr/local/bin/python',
#13 0.959 '/root/comfy/ComfyUI/custom_nodes/ComfyUI-Manager/cm-cli.py', 'install',
#13 0.959 'qq-nodes-comfyui', 'ComfyUI-KJNodes', 'rgthree-comfy', '--no-deps']
#13 DONE 1.0s

@ltdrdata
Copy link
Member

Make sure ComfyUI-Manager is up to date.

@M1kep
Copy link
Author

M1kep commented Dec 29, 2024

Make sure ComfyUI-Manager is up to date.

The full install is managed via comfy-cli, does it not pull down the latest manager?

There doesn't appear to be a --no-deps flag:
https://github.com/ltdrdata/ComfyUI-Manager/blob/5a9270de856ded4ce0c42c6651dc8a9a64845986/cm-cli.py#L499-L517

Seems like this requires the feat/cnr branch

Installing feat/cnr via --manager-url seems to cause ComfyUI-KJNodes to fail to install though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants