Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU-only mode is non-existent #185

Open
ohenepee opened this issue Sep 15, 2024 · 4 comments
Open

CPU-only mode is non-existent #185

ohenepee opened this issue Sep 15, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@ohenepee
Copy link

Describe the bug
Installing with the --cpu option still installs all NVIDIA requirements. All the gigabytes of NVIDIA GPU dependencies were downloaded, even though I have no NVIDIA card and I specifically added --cpu. After successful installation, launching fails with
RuntimeError: Found no NVIDIA driver on your system. Please check that you have an NVIDIA GPU and installed a driver from http://www.nvidia.com/Download/index.aspx

To Reproduce

python3 -m venv ./venv
source ./venv/bin/activate
pip install comfy-cli
comfy --here install --cpu
comfy launch

Expected behavior
NVIDIA requirements are not needed for CPU-only installations. And there should be a way to pass the --cpu option to the comfy launch command.

@ohenepee ohenepee added the bug Something isn't working label Sep 15, 2024
@ltdrdata
Copy link
Member

Oh, that's not an install option, it's a launch option.
comfy launch -- --cpu

@ohenepee
Copy link
Author

ohenepee commented Sep 16, 2024

Oh wow, comfy launch --help doesn't show this... its rather present in comfy install --help

And actually prints "Installing for CPU" or something similar.

Thanks btw, wouldn't have figured it out.

@ltdrdata
Copy link
Member

ltdrdata commented Sep 17, 2024

Oh wow, comfy launch --help doesn't show this... its rather present in comfy install --help

And actually prints "Installing for CPU" or something similar.

Thanks btw, wouldn't have figured it out.

image

Actually -- <extra args ...> is that.
--cpu is arguments of ComfyUI core itself not a part of comfy-cli.

-- is used to set ComfyUI's own options.
For example, you can use it like this: comfy launch -- --listen 0.0.0.0 --port 1111

@snomiao
Copy link
Member

snomiao commented Sep 18, 2024

Oh wow, comfy launch --help doesn't show this... its rather present in comfy install --help
And actually prints "Installing for CPU" or something similar.
Thanks btw, wouldn't have figured it out.

image

Actually -- <extra args ...> is that. --cpu is arguments of ComfyUI core itself not a part of comfy-cli.

-- is used to set ComfyUI's own options. For example, you can use it like this: comfy launch -- --listen 0.0.0.0 --port 1111

Should we make a --help command on extra args...? @ltdrdata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants