Move setting impl from ComfySettingsDialog to settingStore #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
commented
Dec 29, 2024
| @@ -1001,15 +1001,9 @@ export class ComfyApp { | |||
| */ | |||
| async setup(canvasEl: HTMLCanvasElement) { | |||
| this.canvasEl = canvasEl | |||
| // Show menu container for GraphView. | |||
There was a problem hiding this comment.
No longer necessary as the setting value initialization will trigger the vue watcher to properly set the display attr of legacy menu.
huchenlei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2080. #2080 removes the last setting registered before the start of vue app, which enables only keep a single copy of setting value and def in pinia
settingStore.Previously
settingStoreandComfySettingsDialogboth own a copy of setting definitions and setting values, and theComfySettingsDialogis driving the state change, i.e.settingStoreis callingComfySettingsDialog.This PR reverse the relationship so that now only single copy of state exists in
settingStoreandComfySettingsDialognow calls intosettingStore. All methods onComfySettingsDialogare now marked as deprecated.