Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement color palette in Vue #2047

Merged
merged 25 commits into from
Dec 26, 2024
Merged

Implement color palette in Vue #2047

merged 25 commits into from
Dec 26, 2024

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Dec 25, 2024

Resolves #1996

image

┆Issue is synchronized with this Notion page by Unito

@huchenlei
Copy link
Member Author

huchenlei commented Dec 25, 2024

Playwright test diff:
image

Caused by fallback to default theme when value is not set. The litegraph default and default dark theme have minor color diff.

@huchenlei huchenlei added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Dec 25, 2024
@huchenlei huchenlei merged commit db572a4 into main Dec 26, 2024
2 checks passed
@huchenlei huchenlei deleted the vue_color branch December 26, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Browser Test Expectations New browser test screenshot should be set by github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DevTask] Move Comfy.ColorPalette feature out of extensions/core
1 participant