Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n-custom-nodes action #1991

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Fix i18n-custom-nodes action #1991

wants to merge 10 commits into from

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Dec 19, 2024

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei requested a review from a team as a code owner December 19, 2024 18:05
@huchenlei huchenlei changed the title Fix git username on i18n-custom-nodes action Fix i18n-custom-nodes action Dec 19, 2024
@huchenlei huchenlei requested a review from snomiao December 19, 2024 20:25
@huchenlei
Copy link
Member Author

@snomiao Can you take a look on why we can fork the repo sucessfully but cannot push to that forked repo? Locally I ran the command with the comfy-pr-bot token, it worked fine and created the remote branch, but in action context, the permission is not getting through.

@huchenlei huchenlei marked this pull request as draft December 19, 2024 22:04
@snomiao
Copy link
Member

snomiao commented Dec 20, 2024

I guess because github action will overwrite GH_TOKEN and GITHUB_TOKEN
You could try other name on the env var, like GH_TOKEN_PR @huchenlei

@snomiao Can you take a look on why we can fork the repo sucessfully but cannot push to that forked repo? Locally I ran the command with the comfy-pr-bot token, it worked fine and created the remote branch, but in action context, the permission is not getting through.

@snomiao snomiao marked this pull request as ready for review December 20, 2024 02:50
@huchenlei huchenlei marked this pull request as draft December 20, 2024 16:49
@huchenlei
Copy link
Member Author

@snomiao It seems like the permission issue is still not fixed. See https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/12424648106/job/34690142267

@snomiao snomiao self-assigned this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants