Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU selection to desktop installer #1888

Merged
merged 14 commits into from
Dec 16, 2024
Merged

Add GPU selection to desktop installer #1888

merged 14 commits into from
Dec 16, 2024

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Dec 12, 2024

GPU installation options

  • Requires Add GPU selection to installer desktop#468
  • Adds GPU selection screen
  • Pre-selects detected & supported GPU type
  • User may pick any valid choice for their platform
    e.g. Apple GPU not available on win32
  • Installs the appropriate pytorch for the selection
  • Adds option to install CPU-only mode (total venv download ~300MB)
installer-gpu-ii.mp4

Incomplete

  1. The "manual configuration" option only has logic to bypass the torch install. It creates dir structure and sets up user config, then errors out. Users can just close the app and do their manual install at this point.
    This UX issue will be resolved, but is currently functional (it is also a power user option).

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered force-pushed the gpu-selection branch 2 times, most recently from bd9485f to 661d727 Compare December 14, 2024 08:16
Copy link

socket-security bot commented Dec 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@comfyorg/[email protected] None 0 17.4 kB k1oride

🚮 Removed packages: npm/@comfyorg/[email protected]

View full report↗︎

@huchenlei huchenlei marked this pull request as ready for review December 16, 2024 22:50
@huchenlei huchenlei requested review from a team as code owners December 16, 2024 22:50
@huchenlei huchenlei merged commit 601b739 into main Dec 16, 2024
2 checks passed
@huchenlei huchenlei deleted the gpu-selection branch December 16, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants