Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter embeds not working properly. #108

Open
Rtizer-9 opened this issue Apr 5, 2020 · 5 comments
Open

Twitter embeds not working properly. #108

Rtizer-9 opened this issue Apr 5, 2020 · 5 comments
Labels
whitelist/rules A redirection or functionality is broken by CleanLinks

Comments

@Rtizer-9
Copy link

Rtizer-9 commented Apr 5, 2020

I don't know if it's because of some recent commit because it never used to happen before.

Every page with a tweet embedded is broken.
Cleanlinks is intercepting the origin url in "platform.twitter.com/widgets......origin=url"

Eg: https://www.forbes.com/sites/lisettevoytko/2020/03/13/twitters-most-liked-tweet-of-the-week-elon-musk-dismisses-coronavirus-fears/#4cff708c1aff
https://www.vox.com/recode/2020/3/19/21185417/elon-musk-coronavirus-tweets-panic-ventilators-chloroquine-tesla-factory
https://time.com/5470727/most-tweeted-about-celebrites-2018/
https://www.newslaundry.com/2016/07/18/when-subramanian-swamy-trolled-his-own-daughter

You might wanna look into other intercepted urls as well in all these pages. For eg: cdn.embed is also getting blocked which is being used to show tweet.

@Rtizer-9

This comment has been minimized.

@Cimbali

This comment has been minimized.

@Cimbali
Copy link
Owner

Cimbali commented Apr 6, 2020

So this is a case of functionality vs. privacy. twitter will not let you load the iframe if you don’t report the origin URL.

@Cimbali
Copy link
Owner

Cimbali commented Apr 6, 2020

It’s also worth nothing that this doesn’t break the embedding of twitter content, only its rendering. I.e. instead of the following:

image

You get this:

image

So missing additional info such as the reply, and missing some context as the tweet now looks similar to the rest of the article. Importantly, the metadata (tweet author / date) and link to the original tweet (in the date) are still there so you’re 1 click away from the full content.

@Cimbali Cimbali added the whitelist/rules A redirection or functionality is broken by CleanLinks label Apr 6, 2020
@Rtizer-9
Copy link
Author

Rtizer-9 commented Apr 6, 2020

I was searching about how this whole tweet thing is implemented in various scenarios and found several things including this entry

@@||platform.twitter.com/widgets/widget_iframe.$subdocument
in fanboy annoyance list with
syndication.twitter.com blocked in every adblocker.

The embedding does break on sites which doesn't have that kind of rendering implemented.

I also found about https://nitter.net (privacy focused twitter frontend) and was thinking maybe through some another redirection mechanism, the resource can be fetched from it. I don't know if it's really possible.

You're right that its a case of functionality vs. privacy. I think at the moment, fanboy's approach is best if adblockers like ublock can trust that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whitelist/rules A redirection or functionality is broken by CleanLinks
Projects
None yet
Development

No branches or pull requests

2 participants