Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeomLib_Tool Parameter result U is inaccessible #45

Open
voneiden opened this issue Jul 2, 2022 · 3 comments
Open

GeomLib_Tool Parameter result U is inaccessible #45

voneiden opened this issue Jul 2, 2022 · 3 comments

Comments

@voneiden
Copy link

voneiden commented Jul 2, 2022

The current OCP GeomLib_Tool.Parameter_s function stores the computed result in the 4th reference argument U and returns a bool indicating success.

https://github.com/CadQuery/OCP/blob/036b08c136528fecb6df570453be218df0ed72f6/opencascade/GeomLib_Tool.hxx#L51

Return value should probably be Tuple[bool, float] or something along those lines.

@voneiden
Copy link
Author

voneiden commented Jul 2, 2022

In the draft PR #46 I've presented one approach. Any thoughts on if this is worth pursuing further? If yes, I can volunteer to try to dig out if this impacts cadquery codebase in any way.

@voneiden
Copy link
Author

voneiden commented Jul 2, 2022

Also I suppose if we do pursue this, the solution should support any return value, not just a hardcoded Standard_Boolean?

@adam-urbanczyk
Copy link
Member

adam-urbanczyk commented Jul 2, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants