Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observed VRAM Memory Leak #61

Open
xD0135 opened this issue Nov 30, 2024 · 3 comments
Open

Observed VRAM Memory Leak #61

xD0135 opened this issue Nov 30, 2024 · 3 comments
Labels
Bug Unexpected behavior

Comments

@xD0135
Copy link

xD0135 commented Nov 30, 2024

🔘 Operating system

Linux (Arch-like)

🔘 Runtime enviroment

PyAPP Executables (experimental)

🔘 Python version

N/A

🔘 GPU Vendor

NVIDIA Desktop

🔘 Description

Version:
$ ./depthflow-linux-amd64-v0.8.0.bin --version
DepthFlow 0.8.0 linux-amd64

I observed a memory leak when continuously rendering the video after playing around with the animation settings.

This is when I simply click the render button for the first time, everything looks good:
image

This is after the 4th click on Render
image

And this is after the 8th click on Render
image

To reproduce this issue, simply keep clicking on the Render button and monitor your VRAM usage, and you'll see the issue.

🔘 Traceback

No response

@xD0135 xD0135 added the Bug Unexpected behavior label Nov 30, 2024
@Tremeschin
Copy link
Member

Tremeschin commented Nov 30, 2024

Oh yea, I did some recent work on fixing a couple dumb memory leaks here and there, the one you're describing (vram) is probably fixed on this commit BrokenSource/ShaderFlow@6080f4b not present on the v0.8, as well as (system ram) on BrokenSource/ShaderFlow@ca6c33e

I'm a bit of far away from a v0.9 release as there's lots of changes and additions, you could run directly from source https://brokensrc.dev/get/source/ for fixes and new features https://brokensrc.dev/about/changelog/#0.9.0-depthflow temporarily, beware dragons! (I'll be on a month long road trip on dec 20th, could be a 2025 release 😅)

I'm working internally on properly sharing models, thread safety, etc this week. I should add a jobs queue to the webui to avoid recreating the scenes and for thread workers to render the jobs, will be much more leak-resistant, no recreation of opengl contexts, faster render times (no init), etc.

@xD0135
Copy link
Author

xD0135 commented Dec 1, 2024

Awesome! Thank you so much for this great work! Feel free to close, or keep it open until v0.9.0 is released for tracking purposes 😺

@Tremeschin
Copy link
Member

I'll keep it open and move to depthflow repo (even tho it's mainly the other proj issues) for awareness until the 0.9 yea :)

@Tremeschin Tremeschin transferred this issue from BrokenSource/BrokenSource Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected behavior
Projects
None yet
Development

No branches or pull requests

2 participants