New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Faster SSIM #15

Open

ArthurBrussee opened this issue Nov 11, 2024 · 1 comment

Labels

Owner

ArthurBrussee commented Nov 11, 2024

SSIM is quite slow currently eating a good chunk of time each step. There's two improvements here:

Implement seperable convolutions a la https://github.com/VainF/pytorch-msssim/blob/master/pytorch_msssim/ssim.py, which could be a bit faster
Implement a custom fully fused kernel a la https://github.com/rahul-goel/fused-ssim

Some future CubeCL updates will also help with faster convolutions, particularly on non-web backends.

ArthurBrussee added the good first issue label

Owner Author

ArthurBrussee commented Nov 13, 2024

Probably best to wait for #14 to land, as otherwise small scalar kernels will have disproportionate overhead.

ArthurBrussee removed the good first issue label

ArthurBrussee mentioned this issue

Disable SSIM on wasm for now #31

Merged

ArthurBrussee added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment