Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to switch the guest over to using a
World
struct instead of global functions to help resolve #725 and #230 and to enable #71 in the future.However, there are a few blocking issues:
AnimationNode
Clone
andDrop
implementations rely on modifying the ECS globally, which doesn't work when there's aWorld
floating around. I've disabled this for now just to make it compile, but that's not a workable solution.World
through, including event subscriptions.I'm leaving this as a draft PR to pick up later, but it seems like something we should do at some point.