Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create better UI for incorrect/invalid GitHub token #5854

Open
amanape opened this issue Dec 27, 2024 · 0 comments
Open

Create better UI for incorrect/invalid GitHub token #5854

amanape opened this issue Dec 27, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request frontend Related to frontend

Comments

@amanape
Copy link
Member

amanape commented Dec 27, 2024

image

What problem or use case are you trying to solve?
If the user enters an incorrect GitHub token through the "Connect to GitHub" modal, two toasts appear that don't clearly explain the issue.

image

Actually, the 500 status code error is due to a failed request to /api/github/repositories?sort=pushed&page=1&per_page=100 which should not execute at this time

Describe the UX of the solution you'd like
We previously re-opened the modal if the request failed, we should consider bringing this behaviour back. Instead of display an error toast here, re-open the modal and show an error message above or under the token input

@amanape amanape added bug Something isn't working enhancement New feature or request frontend Related to frontend labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request frontend Related to frontend
Projects
None yet
Development

No branches or pull requests

1 participant