Highres Fix always on??

[Weatherby43]

Hello, I'm not sure what branch I'm on atm, (I thought it was Master but it might not be), but my UI is different from what it was. Now, instead of a 'embed/network' button to bring up the list of TI/Hypernetworks/Checkpoints/LORA/Lycoris there are tabs along the top: Generate/Textual Imbed/Hypernetworks/Checkpoints/Lora/Lyrcoris... Those are fine! Those, in fact, are preferable to the old button style imo. But, tonight when I launched A1111 I noticed that the checkbox for Highres Fix was gone and it was now a nested menu instead... Which concerns me because it seems like Highres fix is now always on. I explored this a little and noticed the upscaler drop down box now has a 'None' option... However, when setting it to None and starting a gen, the gen throws an error about 0 values and behaves as if Highres fix was still taking place. Instead of 2 minutes or so for an image, it was taking 10. Is there a way to turn off Highres fix or a fix for this that has yet to be deployed perhaps?

[freecoderwaifu]

The way it works now, at least on my side, is if the dropdown is expanded then hiresfix = on, if it's contracted = off. This dropdown is actually an improvement, since the old way didn't always expand the hires fix options on UI (re)load and they sometimes stuck and had to enable and disable it a couple of times to get them to show up.

However, I think the state of the dropdown should be saved, maybe using the Defaults button in Settings.

[catboxanon]

Yeah, it's now an accordion that behaves as a checkbox.

stable-diffusion-webui/modules/ui.py

Line 442 in 3c00e41

with InputAccordion(False, label="Hires. fix") as enable_hr:

stable-diffusion-webui/modules/ui_components.py

Lines 76 to 80 in 3c00e41

	class InputAccordion(gr.Checkbox):
	"""A gr.Accordion that can be used as an input - returns True if open, False if closed.
	Actaully just a hidden checkbox, but creates an accordion that follows and is followed by the state of the checkbox.
	"""

[BigMeatyClaws]

This really, really ought to be mentioned somewhere. Confusing as all hell. Was about to make a bug/feature report.

On second thought, maybe make it have on when expanded, off contracted written somewhere?

[Weatherby43]

I was sort of suspecting that's how it worked! Thanks for the info!

[larinius]

Oh, my God, what an insane person decided to make dropdown work as checkbox?!
And it also has CHEKCBOX. It is impossible to understand with normal human brains....