Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Custom Diffusion Extension no longer maintained by the author #73

Open
1 task done
Harvester62 opened this issue May 31, 2023 · 7 comments
Open
1 task done

Comments

@Harvester62
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What happened?

The developer of the Custom Diffusion extension is no longer maintaining it as per his reply to this bug report on his repository: guaneec/custom-diffusion-webui#10 (comment)

Steps to reproduce the problem

  1. Go to ....
  2. Press ....
  3. ...

What should have happened?

To keep an extension in the list of available ones, it should be actively maintained, otherwise it can lead to errors and user complaints. If a developer is not interested anymore to maintain his extension, this can be forked by another developer and kept updated, as it happened with other extensions (like Images Browser).

Commit where the problem happens

20ae71faa8ef035c31aa3a410b707d792c8203a3

What Python version are you running on ?

Python 3.10.x

What platforms do you use to access the UI ?

Windows

What device are you running WebUI on?

Nvidia GPUs (GTX 16 below)

What browsers do you use to access the UI ?

Mozilla Firefox

Command Line Arguments

--xformers --opt-split-attention --disable-safe-unpickle --api --allow-code --administrator --medvram --theme dark

List of extensions

immagine

Console logs

venv "C:\sd-web-ui\venv\Scripts\Python.exe"
Python 3.10.6 (tags/v3.10.6:9c7b4bd, Aug  1 2022, 21:53:49) [MSC v.1932 64 bit (AMD64)]
Version: v1.3.0
Commit hash: 20ae71faa8ef035c31aa3a410b707d792c8203a3
Installing requirements


[auto-sd-paint-ext] Commit hash: 00714355890aefa9a09e7fdb1f9a136c46a17618
[auto-sd-paint-ext] Auto-update disabled.

Installing requirements for Batch Face Swap



Fetching updates for midas...
Checking out commit for midas with hash: 1645b7e...

Installing requirements for scikit_learn



Installing requirements for Prompt Gallery






loading Smart Crop reqs from C:\sd-web-ui\extensions\sd_smartprocess\requirements.txt
Checking Smart Crop requirements.

Installing requirements for Seed Travel

Installing requirements for Shift Attention


Installing imageio-ffmpeg requirement for depthmap script
Installing pyqt5 requirement for depthmap script






Launching Web UI with arguments: --xformers --opt-split-attention --disable-safe-unpickle --api --allow-code --administrator --medvram --theme dark
no config file: C:\sd-web-ui\extensions\Stable-Diffusion-Webui-Prompt-Translator\prompt_translator.cfg
Scan MarianMT model
No MarianMT folder, no need scan
Loading booru2prompt settings
Error loading script: main.py
Traceback (most recent call last):
  File "C:\sd-web-ui\modules\scripts.py", line 263, in load_scripts
    script_module = script_loading.load_module(scriptfile.path)
  File "C:\sd-web-ui\modules\script_loading.py", line 10, in load_module
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "C:\sd-web-ui\extensions\custom-diffusion-webui\scripts\main.py", line 32, in <module>
    ui_extra_networks_initialize_bak = ui_extra_networks.intialize
AttributeError: module 'modules.ui_extra_networks' has no attribute 'intialize'

2023-05-31 18:28:10,721 - sd_dynamic_prompts.dynamic_prompting - INFO - Starting Dynamic Prompts v2.11.10
[AddNet] Updating model hashes...
0it [00:00, ?it/s]
[AddNet] Updating model hashes...
0it [00:00, ?it/s]
ControlNet v1.1.204
ControlNet v1.1.204
Hypernetwork-MonkeyPatch-Extension found!
Installing pywin32
Image Browser: ImageReward is not installed, cannot be used.
Loading weights [9012b038a9] from C:\sd-web-ui\models\Stable-diffusion\sd-v1-5-pruned-emaonly_fp16.ckpt
Create LRU cache (max_size=16) for preprocessor results.
Creating model from config: C:\sd-web-ui\configs\v1-inference.yaml
LatentDiffusion: Running in eps-prediction mode
DiffusionWrapper has 859.52 M params.
Applying optimization: xformers... done.
Textual inversion embeddings loaded(0):
Model loaded in 3.5s (load weights from disk: 0.9s, create model: 0.7s, apply weights to model: 0.6s, apply half(): 1.1s).
Create LRU cache (max_size=16) for preprocessor results.
Create LRU cache (max_size=16) for preprocessor results.
1920 1080
1030
INFO:     Started server process [17112]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://127.0.0.1:5173 (Press CTRL+C to quit)
INFO:     127.0.0.1:51155 - "GET / HTTP/1.1" 200 OK
add tab
*Deforum ControlNet support: enabled*
Running on local URL:  http://127.0.0.1:7860

To create a public link, set `share=True` in `launch()`.
auto-sd-paint-ext:INFO: Add --listen to COMMANDLINE_ARGS to enable usage as a remote backend.
Create LRU cache (max_size=16) for preprocessor results.
Startup time: 95.5s (import torch: 10.4s, import gradio: 2.9s, import ldm: 1.6s, other imports: 3.1s, setup codeformer: 0.4s, load scripts: 55.7s, create ui: 20.3s, gradio launch: 0.9s, scripts app_started_callback: 0.2s).

Additional information

No response

@w-e-w
Copy link
Collaborator

w-e-w commented May 31, 2023

this was always the case
but we simply don't have the resource to test every extension actively we can only rely on user reports
needless to say we don't have the resources to keep track fors of extensions

if an extension is indeed no longer maintained and a viable fork is available
we will make the change to point the index to new repo

as for removing outdated extensions
I personally don't want to do so at least not immediately
not everyone is using the newest version of web UI and thus can still use older versions extensions

it's really all a case by case basis

tldr be made aware via user reports
ideally hopefully the autor themselves would send a message to us

if you have more issues related to extensions I think it's easier if you post it to the extension index repo
as it would have less likely chance of getting buried
https://github.com/AUTOMATIC1111/stable-diffusion-webui-extensions

@w-e-w
Copy link
Collaborator

w-e-w commented May 31, 2023

oh my why do you have so many extensions installed

are you testing every extension?

yes I tagged it as not-an-issue because it's technically "not an issue"
that doesn't mean that I'm not a paying attention to this post

@w-e-w
Copy link
Collaborator

w-e-w commented May 31, 2023

Maybe we can add a no longer maintain tag

I did conceptualize a version system that would provide version compatibility but that hasn't been made yet

@Harvester62
Copy link
Author

I do understand your point and I will follow your suggestion to use that repository for such a things.

Anyway, I do need to have all the working extension installed (or at least those that I do want to translate the UI) because I am the translator of the Italian localization, and I do need to export the localization.json file with all the stuff inside it, otherwise I wouldn't be able to compare it side by side with my it_IT.json file and avoid duplications of labels and descriptions.

I won't install/translate all the available Extensions, but only those that I wish to work on in my spare time. Until another way of managing the localization will be implemented, this is the only way I have found to work with the localization file.

@w-e-w
Copy link
Collaborator

w-e-w commented May 31, 2023

if it is not too much trouble for you
do you mind sending me a list of know non-working or no longer maintain extensions
it would very be helpful if I were to add the no longer maintain working tags

@ClashSAN
Copy link
Collaborator

@Harvester62 puts hard work to test extensions, and custom scripts for translation. He is enabling all the extensions from the index page, and has said before that they need to be all enabled at once for translating extensions.

Consider posting here: https://github.com/AUTOMATIC1111/stable-diffusion-webui-extensions, the things you find important involving extensions. Testing or commentary you have is appreciated.

If you want to look at pruning the older extensions from the index, because its broken and inactive, another similar extension exists, submitting a pull request removing it + asking on their github repo seems suitable. Give a month or more, then remove them. This way we're not going to upset users or creator. You could also put the old extension in the wiki, anybody can edit it now.

@w-e-w w-e-w transferred this issue from AUTOMATIC1111/stable-diffusion-webui Jun 1, 2023
@Harvester62
Copy link
Author

Thank you @ClashSAN and @w-e-w for your replies and support. I will follow your suggestions in case I will find any no longer supported extension or broken ones on https://github.com/AUTOMATIC1111/stable-diffusion-webui-extensions.

I am currently redoing the it_IT.json file due to the re-installation from scratch of SD Web UI v1.3.0, therefore my comments or checks are always compared to the most current version of the SDWUI repository.

I'm quite behind in the translation of the many new Extensions that have been published until now, but I will do my best to translate the most of them.
The very first check and step is always the installation of the Extension, which has to start correctly (that doesn't mean that it works, simply that it doesn't rise any errors at startup). If it does than there are very good chances that it is also properly working.

So @w-e-w , all the extensions that you see in my screenshot have been successfully installed and they should also work properly with the latest version of SDWUI.

Consider also that if I find an incompatible or a dependency error I try to solve the issue, after checking with the extension's repository information and eventually doing a pip check for safety. Currently, by example, I have to see how to install Riffusion because of its dependencies, we'll see; it works in the old installation of SDWUI, so I can find a way to manage it's localization anyway.

Sorry for the wall of text. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants