Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Add Support for Maximum Application Attempts Per Company #935

Open
moudimash99 opened this issue Nov 25, 2024 · 9 comments
Open
Assignees
Labels
enhancement New feature or request stale

Comments

@moudimash99
Copy link

Feature summary

Introduce a configurable maximum number of applications per company, allowing users to specify limits like 5 applications to Google instead of just a boolean option.

Feature description

Currently, the bot offers a binary option (apply_once_at_company: true/false) to either apply once or indefinitely to the same company. This proposed feature introduces a more flexible system where users can define a specific maximum number of applications per company. For example, users could configure the bot to apply to Google up to 5 times but still apply indefinitely to other companies.

This feature would involve:

Updating the work_preferences.yaml file to accept numeric values for apply_once_at_company.
Implementing logic to track and limit applications based on the specified number.

Motivation

Provides users with better control over application strategies by avoiding over-applying to specific companies.

Alternatives considered

No response

Additional context

No response

@moudimash99 moudimash99 added the enhancement New feature or request label Nov 25, 2024
@moudimash99
Copy link
Author

id like to be assigneed to this

@surapuramakhil
Copy link
Contributor

Hey @moudimash99 , can you also take this #832 as both are closely related.

@surapuramakhil
Copy link
Contributor

surapuramakhil commented Nov 25, 2024

feel free to introduce DB if required (considering other proposals etc) - suggest going with simple light weight SQLite if doesn't satisfy needs then go for bigger - MySQL, Postgres etc.

@moudimash99
Copy link
Author

Yeah I think that'll be the next thing I'm going to take, with them both moving forward. We'll need surely a time limit as applying to a company multiple times is only relevant in a time frame. I was thinking of using the current architecture,are there other features that are or will be using a DB as that might be interesting moving forward for even other features

@surapuramakhil
Copy link
Contributor

@cjbbb @moudimash99 can you work together on this and #832, both are highly coupled - it's easy both doing at once

@moudimash99
Copy link
Author

on it chief. @surapuramakhil

@cjbbb wanna have a quick chat sometime about it? it's a simple thing but we can halve the work or so

@cjbbb
Copy link
Collaborator

cjbbb commented Nov 26, 2024

on it chief. @surapuramakhil

@cjbbb wanna have a quick chat sometime about it? it's a simple thing but we can halve the work or so@cjbbb想找个时间快速聊聊这件事吗?这是一件简单的事情,但我们可以将工作量减半左右

hi @moudimash99 what is your discord account, we can chat on it

@moudimash99
Copy link
Author

@cjbbb moudimash99

Copy link

This issue has been marked as stale due to inactivity. Please comment or update if this is still relevant.

@github-actions github-actions bot added the stale label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
Status: In Progress
Development

No branches or pull requests

3 participants