Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Regression When Adding Torrent Files #1351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AnastasiyaSoyka
Copy link

@AnastasiyaSoyka AnastasiyaSoyka commented May 18, 2023

At some point, the parse-torrent dependency was upgraded; the new version of this dependency relies on another dependency named uint8-util which relies on the WebCrypto API for message digest functions.

Unfortunately, the WebCrypto API is only available in secure contexts (HTTPS or localhost). This is likely why the regression was not caught sooner, because a developer would have to go out of their way to load the web app in an insecure context in order to experience the bug.

This PR reverts to the previous version of the offending dependency, which appears to solve the problems users are experiencing with adding torrent files from local filesystem or by URL.

Resolves #1309, resolves #1340.

Ignore VSCode Dev Container files.

Resolves 6c65726f79#1309, resolves 6c65726f79#1340
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gajahduduk
Copy link

forgive the ignorance about how github works, but… has this been fixed? how do you tell what version fixes it, and how to get that version?

@AnastasiyaSoyka
Copy link
Author

forgive the ignorance about how github works, but… has this been fixed? how do you tell what version fixes it, and how to get that version?

@gajahduduk

As I far as I know, this issue has not been fixed. This repository hasn't received any commits in more than a year, so the author is likely too busy or otherwise unable to merge this PR. Are you referring to a version of Transmissionic, or to a version of the offending dependency? If it's the former, you could try installing older versions of Transmissionic until you find one that works in an insecure context. For the latter, the problematic dependency is called parse-torrent, and I found that version 9.1.5 doesn't have this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web UI Error: no web crypto support Not able to add torrent file via web interface since last release
2 participants