Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserve label of ItemURLs when using ItemBuilder.addUrl #120

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

preserve label of ItemURLs when using ItemBuilder.addUrl #120

wants to merge 3 commits into from

Conversation

cze-aeb
Copy link

@cze-aeb cze-aeb commented Oct 6, 2024

Fixes the bug that ItemBuilder drops labels of URLs when using ItemBuilder.addUrl

Fixes #119

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2024

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@cze-aeb cze-aeb force-pushed the bugfix/builder-preserve-url-label branch from 87cb0bb to ca8aaa6 Compare October 6, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: ItemBuilder.addUrl drops label of ItemUrls
1 participant
@cze-aeb